• MamboGator@lemmy.worldEnglish
    95·
    2 years ago

    The junior doesn’t know that these aren’t unused functions. They’re load bearing functions.

  • Bappity@lemmy.worldEnglish
    43·
    2 years ago

    me when first starting out at a job commenting everything I can
    VS
    me a couple years in completely lost because I never updated the comments and now none of them make any sense whatsoever

    • xmunk@sh.itjust.works
      46·
      2 years ago

      Commenting well is a highly advanced skill. I generally prefer no comments on code since it’s less likely to confuse people and I’ll merrily purge auto-doc comments and anything like

      // getId() returns an id

      That comment has negative value.

      • Platypus@sh.itjust.worksEnglish
        8·
        2 years ago

        In my experience refactoring lots and lots of crappy code left by devs long gone, a dev who can write useful comments is by and large a dev who can write code clean and simple enough not to need them. If the code doesn’t have informative names and clear separation of concern, chances are a comment won’t help because the dev didn’t really know what they did that worked in the first place.

        • MagicShel@programming.dev
          12·
          2 years ago

          Generally, yes. However I have been known to document exactly why I’m doing something incredibly stupid - because it’s required but a stupid third party library which, despite being awful, is still better than implementing it myself as a refactor.

        • Bappity@lemmy.worldEnglish
          3·
          2 years ago

          a dev who can write useful comments is by and large a dev who can write code clean and simple enough not to need them.

          my boss is great in this regard and also always has to keep reminding us to write unit tests 😅

  • ericbomb@lemmy.world
    13·
    2 years ago

    Look, it’s me.

    Just let me rewrite ONE report from scratch so it doesn’t check a specific unindexed table that it doesn’t actually need to check and causes the report to be killed by MSQL because it takes too long to run.

    Please just one rewrite. Please.

    Just one little crystal report.

    • justJanne@startrek.website
      4·
      2 years ago

      Often enough, the old code is so badly intertwined that it’s impossible to actually test. Those are the moments where all you can do is nuke it from orbit.